Fix parallel build in top-level Makefile#74
Draft
electrodude wants to merge 3 commits intototalspectrum:masterfrom
Draft
Fix parallel build in top-level Makefile#74electrodude wants to merge 3 commits intototalspectrum:masterfrom
electrodude wants to merge 3 commits intototalspectrum:masterfrom
Conversation
Author
|
Not quite finished yet; it sometimes fails while compiling PropLoader. |
electrodude
force-pushed
the
fix-makefile
branch
from
979440f to
f4e5a33
Compare
Every documentation file expected to be able to rewrite pandoc.yml, causing conflicts when make tried building different doc files at the same time. Now each file's .yml file gets a unique name.
Why it should be done this way: https://www.gnu.org/software/make/manual/make.html#MAKE-Variable
Not only is this a waste, but if the second build of a file was written while the first was still being read, it would cause the build to fail.
electrodude
force-pushed
the
fix-makefile
branch
from
f4e5a33 to
7b80fbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit fixes the conflict over
pandoc.ymlthat would occur when attempting a parallel build. The second corrects some explicit recursive invocations ofmakewith the correct$(MAKE), as explained in the manual.@drwonky's #72 has a comment about how parallel build didn't work; this should fix that, at which point the SPEC file can be updated to use parallel build.